Skip to content

Add splitlfqgroups: split an LFQ design into independent quantification groups by SDRF columns - #84

Merged
daichengxin merged 1 commit into
bigbio:devfrom
Shen-YuFei:dev
Oct 9, 2026
Merged

daichengxin merged 1 commit into
bigbio:devfrom
Shen-YuFei:dev

Conversation

@Shen-YuFei

Copy link
Copy Markdown
Contributor

Summary

Moves the LFQ group splitter of bigbio/quantms#734 (bin/split_lfq_groups.py) into quantms-utils, as requested in that review, so quantms can run it from the quantms-utils container.

quantmsutilsc splitlfqgroups --sdrf full.sdrf.tsv --design full_openms_design.tsv \
    --column 'comment[instrument]' --column 'comment[gradient duration]' [--output DIR]
  • Each combination of the given SDRF column values is one group. The command writes <group>.sdrf.tsv and <group>_openms_design.tsv per group, and the manifest lfq_groups.tsv (group, run, files and grouping values).
  • No run is dropped. The command fails when a grouping value is missing, a run belongs to two groups, the SDRF and design run sets differ, a fractionated sample crosses groups, or the design references missing sample metadata.
  • Group IDs are hashes of the column names and values, so they do not depend on row order. Sample and fraction-group IDs are renumbered within each group; conditions and biological replicates are kept.
  • The code is the same as in quantms; only the entry point is now a click command. It uses the standard library only, so there is no new dependency.

Verification

  • pytest: 36 passed, 1 skipped (27 before). tests/test_split_lfq_groups.py ports the 8 quantms tests and adds one CLI test.
  • flake8 . --select=E9,F63,F7,F82: 0.
  • The new module with the tools Codacy runs here: Prospector (pycodestyle, pydocstyle, pyflakes, dodgy) and Bandit report nothing; Lizard is below its thresholds.

Follow-up

After a release, bigbio/quantms#734 will call quantmsutilsc splitlfqgroups and drop bin/split_lfq_groups.py.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 06:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 68bd7d72-0184-42e6-849c-5e9bf33dcd09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 54 complexity

Metric Results
Complexity 54

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@daichengxin
daichengxin merged commit 657602d into bigbio:dev Oct 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants