Repository navigation
Move CodeQL to v4 and also scan JavaScript and the workflows - #135
Merged
Merged
Conversation
CodeQL Action v3 is deprecated in December 2026. Also analyze javascript-typescript (skipping the vendored minified libraries) and actions, which checks the workflow files themselves. None of the three need a build, so drop autobuild and use build-mode none, along with the setup template's leftover comments and Swift runner logic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage for e2e tests for Python 3.14
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 29 29
Lines 2391 2391
=======================================
Hits 1589 1589
Misses 802 802 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🚀 Staging Preview Deployed! URL: https://preview-seating-pr-135-137456085712.us-west1.run.app |
pancakereport
marked this pull request as draft
October 16, 2026 23:14
pancakereport
marked this pull request as ready for review
October 16, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codeql.ymlusesgithub/codeql-action@v3, which GitHub plans to deprecate in December 2026 (changelog). Repos with their own CodeQL workflow, like this one, have to move to v4 themselves. This also widens what CodeQL scans beyond Python.Changes
initandanalyzego to@v4.javascript-typescript: scansserver/static/js/(layout_preview.js,utils.js).server/static/vendor/,tests/a11y/axe.min.js), viapaths-ignore.<script>blocks in the.j2templates. CodeQL reads.jsand.htmlfiles, not Jinja templates.actions: scans the workflow files themselves, for script injection from untrusted input, checking out PR code in privileged workflows, and overly broad permissions.build-mode: none, so theautobuildstep is gone./language:python, so existing Python alerts carry over.Testing
This PR's own checks are the test: the Analyze job should run three times (python, javascript-typescript, actions) and upload results under three categories. Any new alerts from the two new languages show up under Security → Code scanning.
🤖 Generated with Claude Code