Repository navigation
feat: Report dispatch failures with their HTTP status and request - #117
Open
whisperity wants to merge 1 commit into
Open
whisperity wants to merge 1 commit into
whisperity wants to merge 1 commit into
Conversation
When GitHub answers the dispatch request with an error that has an
empty body, Octokit builds an error with an empty message.
`core.setFailed("")` then writes an `::error::` command without text,
which the runner discards. The step failed with nothing in its log
after "Calling GitHub API to dispatch workflow…".
Every failure is now reported with a non-empty text, naming the HTTP
status, the request, and what the response body said, or that it was
empty. Network failures without a response are named as such, and
the error handler was fixed to ensure that non-`Error` objects are
also handled appropriately.
Long response bodies, such as HTML error pages, are collapsed to a
single line and cut.
A failure of the dispatch request itself names the workflow, the
repository and the ref. After a server or network error it also warns
that GitHub may still have created the run, so that the workflow's run
history is checked before dispatching again.
whisperity
force-pushed
the
fix/issue-116
branch
from
November 4, 2026 17:39
04782bb to
ce75785
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GitHub answers the dispatch request with an error that has an empty body, Octokit builds an error with an empty message.
core.setFailed("")then writes an::error::command without text, which the runner discards. The step failed with nothing in its log after "Calling GitHub API to dispatch workflow…".Every failure is now reported with a non-empty text, naming the HTTP status, the request, and what the response body said, or that it was empty. Network failures without a response are named as such, and the error handler was fixed to ensure that non-
Errorobjects are also handled appropriately.Long response bodies, such as HTML error pages, are collapsed to a single line and cut.
A failure of the dispatch request itself names the workflow, the repository and the ref. After a server or network error it also warns that GitHub may still have created the run, so that the workflow's run history is checked before dispatching again.
Fixes #116.