Repository navigation
Conversation
Imkkey
marked this pull request as ready for review
October 14, 2026 06:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A dictionary-backed
Choicecurrently raises rawTypeErrorfor list, dict, or set configuration values. Besides losing the setting's name, this preventsOneOffrom reaching a later valid collection template.Normalize
TypeErrorfrom the dict-dispatch lookup toValueError, which the existingChoice.converterror handling turns intoConfigValueError. Keep the directchoices[value]lookup and leave the other converters unchanged.Add regression coverage for rejected unhashable values, valid sequence/mapping fallbacks, nested mapping validation, and rejection when no fallback matches. Include compatibility controls for tuple/custom hashable keys, dict-subclass
__missing__, and a custom lookup accepting lists. Verify that errors in sequence and enum converters still propagate directly and throughOneOf. Add an unreleased changelog entry.Validation
On Linux/Python 3.12.14:
test_bump_version_applies_sequential_changelog_updates. Unchanged upstream reproduces that same failure (300 tests pass): the expected changelog underline does not match the October date heading.git diff --checkpass.Prepared and tested with OpenAI Codex assistance. This is a draft for maintainer review.