Repository navigation
Conversation
Imkkey
marked this pull request as ready for review
October 14, 2026 06:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98.
config_dirs()currently lists~/.configbefore an explicitXDG_CONFIG_HOME. If both contain a configuration, the legacy path wins; if neither does,config_dir()creates the new directory under the legacy path. The usage guide describes the XDG location as first.Place nonempty
XDG_CONFIG_HOMEfirst on Unix and macOS, then preserve the existing order of all other candidates. Windows and unset/empty-XDG fallback behavior stay unchanged. Expansion and deduplication continue through the existing code. This follows the narrow ordering approach discussed in #98 and #167; it does not remove legacy lookup paths or add new path validation.Update the search-path documentation and add subprocess regressions with temporary homes. The cases cover existing configurations, new-directory fallback, empty/unset overrides, duplicate expanded paths, multiple system directories, application-specific overrides, macOS ordering and unchanged Windows paths. The macOS and Windows cases mock platform detection; no native-platform test result is claimed.
Two existing tests needed isolation fixes:
FakeHomenow saves/restores its temporary HOME/XDG environment, and the explicit-file reload test disables automatic configuration discovery. Without isolation, those tests can consult the machine's real configuration paths.Validation on Python 3.12.14:
test_bump_version_applies_sequential_changelog_updates.git diff --checkpass.The production change is limited to
util.config_dirs(). Pending #213 still obtains candidate paths through that function; its read-only discovery change is independent. The branches were not combined or tested together. Prepared and checked with OpenAI Codex assistance; draft for maintainer review.