Repository navigation
Validate boolean defaults with boolean templates - #214
Closed
xingzhao-ji wants to merge 1 commit into
Closed
xingzhao-ji wants to merge 1 commit into
xingzhao-ji wants to merge 1 commit into
Conversation
xingzhao-ji
marked this pull request as ready for review
October 14, 2026 17:55
xingzhao-ji
marked this pull request as draft
October 14, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as_template(False)andas_template(True)currently take the integer branch becauseboolsubclassesint. A boolean default therefore accepts numeric values: validating{'enabled': 0.5}against{'enabled': False}returns integer0, while validating withboolcorrectly rejects it.Recognize boolean defaults before integers and reuse
TypeTemplate(bool, default). Missing values retain the supplied boolean default, and existing boolean values retain their identity. Numeric values now raiseConfigTypeError, matching the explicit boolean template.Add shorthand/default/validation tests and an unreleased changelog entry.
Validation
git diff --checkpassed.