Repository navigation
CI: Test the wheel without matplotlib - #961
Merged
Merged
Conversation
Add a Linux job, python_313_no_matplotlib_wheel, that installs neither matplotlib nor seaborn and tests the installed wheel from outside of the source tree, as the tests of the arch-wheels builds do. The install step fails if another package installs matplotlib anyway. A test module that imports matplotlib unconditionally, as three did before #960, then fails to collect in CI instead of in the wheel builds.
bashtage
force-pushed
the
a90-ci-no-matplotlib
branch
from
October 18, 2026 14:27
2f498a8 to
b2c5c1a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 136 136
Lines 30043 30043
Branches 2331 2331
=======================================
Hits 29729 29729
Misses 256 256
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
a90-ci-no-matplotlib, one commit; #960, which it was built on, is merged, so the diff is only CI files (ci/azure/azure_template_posix.yml,ci/azure/install-posix.sh).The arch-wheels builds test the installed wheel without matplotlib. arch's own CI
always installs it, so three new test modules that imported matplotlib at module
level passed every check here and failed in every arch-wheels job (#960). This
job catches that in CI:
python_313_no_matplotlib_wheel: Python 3.13 withNO_MATPLOTLIB: 'true'andtest.wheel: true. It builds the wheel, installs itin site-packages and runs
arch.test()from a directory outside the sourcetree, as the arch-wheels builds do.
arch.test()exits with pytest's status, soa collection error fails the job.
install-posix.sh: withNO_MATPLOTLIB, it leaves out matplotlib andseaborn, which needs it. After the install, it fails if matplotlib can be
imported anyway, for example because another package pulled it in, so the job
cannot silently test with matplotlib.
The comparison is case-insensitive, because Azure can pass a YAML
trueas"True". The other legs are unchanged. Checked locally: the script's syntax
(
bash -n), the YAML (11 Linux legs), and the absence check with and withoutmatplotlib.
🤖 Generated with Claude Code