Repository navigation
ci: add core product validation merge gate - #2477
Merged
Merged
Conversation
codeforester
force-pushed
the
ci/2452-20261005-core-product-merge-gate
branch
from
October 5, 2026 14:12
4d292be to
b463394
Compare
codeforester
force-pushed
the
ci/2452-20261005-core-product-merge-gate
branch
from
October 5, 2026 14:12
b463394 to
2fecaff
Compare
5 tasks
codeforester
commented
Oct 5, 2026
codeforester
left a comment
codeforester
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed head 2fecaff against #2452 ("Partially addresses", so the issue stays open for the ruleset change). No blocking findings.
if: always()together with an explicit!= successcheck on each dependency is the right aggregate pattern: a failed, cancelled or skipped lane fails the gate, so the check can't go green when a lane didn't run. None of the five needed jobs has a job-levelif:, so docs-only PRs won't make the gate fail by default.needs.python.resultcovers the whole Python matrix, so any failing version fails the gate.- CI is green (22/22), including the new job.
One sequencing note is inline: the doc text describes repo configure behavior that only exists once #2478 lands.
| compatibility evidence outside this aggregate, while Project Intake remains | ||
| advisory. After the workflow has produced a trusted successful status, the | ||
| repository owner may explicitly add the exact `Core product validation` check | ||
| to the default-branch ruleset. `basectl repo configure` preserves that |
Collaborator
Author
There was a problem hiding this comment.
Sequencing (non-blocking): "basectl repo configure preserves that additional required check" is only true after #2478 (preserve existing repository protections) merges. On current main, repo configure rebuilds the ruleset from Base's template, which is the bug #2451 tracks. Either merge #2478 first, or soften this sentence until it lands. Otherwise an owner who adds Core product validation to the ruleset and later runs repo configure would lose it.
This was referenced Oct 5, 2026
codeforester
added a commit
that referenced
this pull request
Oct 6, 2026
## Summary - Fixes #2480 by documenting the ordering dependency around custom required checks. - Warns that older Base revisions can replace the named ruleset and remove a manually added check when `repo configure` is rerun. - Makes preservation a documented prerequisite while keeping `Core product validation` an explicit repository-owner decision. - Resolves the merge conflict with the current `main` documentation for the aggregate validation status. ## Issue Fixes #2480 Follow-up to #2477; the wording addresses the review comment about preserving `Core product validation` before ruleset reconciliation is available. ## Validation - `git diff --check` - `PYTHONPATH="$PWD/cli/python:/Users/rameshhp/work/base-cli/lib/python" /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest -q tests/test_contract_hardening.py tests/test_github_workflows.py cli/python/base_github_projects/tests/test_project_rest.py` — 62 passed. - Verified the merge commit has `origin/main` as its second parent and no unmerged paths. ## Notes Documentation-only change; no runtime behavior changes. The PR remains open for hosted checks and review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #2452
Summary
Core product validationjob to the existing Tests workflow.The live repository ruleset still needs a separately authorized settings change after this check has produced a trusted successful run. The exact check context is
Core product validation.Validation
pytest tests/test_github_workflows.py -q— 24 passedgit diff --checkThe issue remains open for the live ruleset update and readback.