Repository navigation
docs(report): correct which metrics the report charts - #215
Closed
0x00101010 wants to merge 2 commits into
Closed
0x00101010 wants to merge 2 commits into
0x00101010 wants to merge 2 commits into
Conversation
ChartGrid renders only SORTED_CHART_CONFIG entries (report/src/components/ChartGrid.tsx:45).
ChartGrid can resolve a listed key to one labeled variant (report/src/components/ChartGrid.tsx:24).
Collaborator
🟡 Heimdall Review Status
|
meyer9
approved these changes
Oct 31, 2026
Collaborator
|
Review Error for meyer9 @ 2026-10-31 14:58:02 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why
docs/report-data-contract.mdsaid that metric keys missing fromreport/src/metricDefinitions.ts"still render, just with raw key names".ChartGridonly charts the metrics listed inCHART_CONFIG, so a producer adding a new key gets no chart and no hint why. #214 hit this: the builder validity metrics were scraped but never shown until they were added toCHART_CONFIG.What
metricDefinitions.ts.Notes
resolveMetricKeycan chart one labeled variant (<listed-key>_<label>) under a listed entry's chart. One reviewer wanted that spelled out. I kept it out because the chart still belongs to the listed metric, and spelling it out would add new explanation to the doc.Testing
Evidence
Review: ready | med, 80% | light (docs-only diff): claude-sonnet-5-5 + gpt-6-luna (reviewers split on the final wording; see Notes)
report/src/components/ChartGrid.tsx:45maps onlySORTED_CHART_CONFIG; no other component rendersExecutionMetricskeysreport/src/components/ChartGrid.tsx:24-38