Repository navigation
chore: track microsoft/playwright-cli at 4bc00fb - #21
Merged
Merged
Conversation
Resolves the blocked merge of tests/integration.spec.ts (b85c7a7 -> 4bc00fb). Upstream's update-check tests use an npm registry fixture; our update check reads GitHub releases, so our cases stay. From microsoft#502 the plain-mode --headed=false argument error is taken; the --json wrapping (microsoft#522) is client code that arrives with a later patchright-core roll. Closes #16 Closes #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the blocked merge reported in #16 and #18:
microsoft/playwright-clib85c7a7 -> 4bc00fb (current HEAD), three conflicts intests/integration/core.spec.ts.What upstream changed in the test, and what we take
-s <name>or--session <name>microsoft/playwright-cli#505): a fake npm registry fixture,.npmrcscoped registries, the check only on setup commands. Our update check reads GitHub releases (src/cli.ts), not npm, so none of these apply; our cases stay as they are.@playwright/clicrashes with a raw Node stack trace on any input error (and prints no JSON with--json) microsoft/playwright-cli#502):open --headed=falsefails with the boolean-option message on stderr, exit 1. Our client already does this, so the assertion is taken.--jsonerror wrapping (fix(cli): report command failures in text and JSON modes microsoft/playwright-cli#522):{ isError, error }on stdout. That is client code in Playwright after 1.64; it arrives with a later patchright-core roll, so it is noted in the test, not asserted.vendor/playwright-cli/tests/integration.spec.tsis the pristine upstream file at 4bc00fb;versions.jsonrecords the commit, date and hash. The files we rewrote (README, CLAUDE.md, workflows, the bots) are report-only and need nothing here.Checked
npm run checkpasses;watch-playwright-clireports "at 4bc00fb; nothing new".tests/integration/core.spec.ts: 5 passed locally.Closes #16
Closes #18
🤖 Generated with Claude Code