Repository navigation
devops(ci): warm up Chrome before integration tests; close superseded roll PRs - #20
Merged
Merged
Conversation
A fresh runner reads the preinstalled Chrome from a cold disk; its first launch took up to a minute and timed out whichever config tests ran first, and starved the 10 s chrome --version probe. Seen on the roll branches (runs 41455020026, 42034887367).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the open roll PRs (#19, and #17 which it supersedes).
Flaky integration tests on a cold runner
The three red CI runs on the roll branches (41455020026, 42034887367, and the macOS cancel in 42222491837 aside) all failed in
tests/integration/config.spec.ts, the first tests to launch Chrome:openspent 40-58 s before the daemon was listening (green runs: 2-26 s), sothe daemon sees our merged config…hit the 60 s test timeout;chrome --versionprobe hit its 10 s limit, so--config points at…gotheadless-user-agent-unknown(leak) instead of theheadless-user-agentnote.Nothing in the roll caused it: the runner reads the preinstalled Chrome from a cold disk on first launch. CI now pays that once in a
Warm up Chromestep (open about:blank+closein a throwaway state dir, 5 min limit, non-fatal) beforetest:integration. Job names are unchanged, so the ruleset's required checks still match.Roll workflow
upstream-roll.ymlcloses older openroll_*PRs (Superseded by #N, branch deleted). A manual run for an older version leaves newer rolls alone (sort -V).pull_requestCI run held inaction_requiredfor a push by the workflow token, which is the only run the ruleset counts..claude/skills/dev/roll.mdsays the same.Checked
npm run check,npm run test:unit(129 passed); the warm-up commands run locally; the superseding loop dry-run against the open PRs closes onlyroll_1.64.2.🤖 Generated with Claude Code