Skip to content

Add a security model section to REVIEW.md - #2490

Merged
kmcginnes merged 1 commit into
mainfrom
t3/add-review-security-model
Oct 28, 2026
Merged

kmcginnes merged 1 commit into
mainfrom
t3/add-review-security-model

Conversation

@kmcginnes

@kmcginnes kmcginnes commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Security reviews keep reporting behavior that's by design, such as no built-in auth or the proxy signing with the host's shared AWS identity, because REVIEW.md never pointed reviewers at the threat model in docs/references/security.md.

User-facing: none

 ## What Important means here
+  - Security changes that widen a documented risk or break a guarantee
+## Security model
+  - docs/references/security.md is the threat model; test and judge against it
+  - deployer-owned behavior is by design
+  - "never / does not / refuses" statements are guarantees; breaking one is Important
+  - Graph Explorer owns untrusted input
 ## Verification bar
+  - a broken guarantee names the doc statement instead of a triggering input
 ## Do not report
-  - Security behavior that's by design: (3 bullets)
+  - Security behavior that's by design, per the Security model section

The section points at the doc instead of copying its by-design list, so the two can't drift.

Merge Danger

Door: two-way

Impact: reviews

Changes how review agents and the PR review bot judge security findings. No code or docs outside REVIEW.md change.

Related


🤖 Written by an AI agent on my behalf.

Layer: 1-review-security-model
@kmcginnes
kmcginnes force-pushed the t3/add-review-security-model branch from c96318f to 8be073b Compare October 28, 2026 19:52

@kmcginnes kmcginnes left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

kmcginnes added a commit that referenced this pull request Oct 28, 2026
## Summary

The access control reference didn't say what the proxy server sends back
from the database, so a layer in front of it had to read the source to
know which status, body, and headers reach the client.

**User-facing:** none

```diff
 ### Reference for access control layers
 **Request headers.** ...
+**Responses.** Status and body passed back as they arrive, error responses
+included. Only `content-type` and `content-encoding` headers passed on.
+Redirects not followed.
 **Paths.** ...
```

`docs/agents/documentation.md` now lists the forwarded response headers
among the facts that section mirrors from code.

## Merge Danger

**Door:** two-way

**Impact:** none

## Related

- Related to #2490. Once this lands, its passthrough bullet in
`REVIEW.md` can cite
`docs/references/security.md#reference-for-access-control-layers`
instead of pointing at `fetchData`.

---

<sub>🤖 Written by an AI agent on my behalf.</sub>
@kmcginnes
kmcginnes merged commit 6863468 into main Oct 28, 2026
1 check passed
@kmcginnes
kmcginnes deleted the t3/add-review-security-model branch October 28, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant