Repository navigation
Add a security model section to REVIEW.md - #2490
Merged
Merged
Conversation
Layer: 1-review-security-model
kmcginnes
force-pushed
the
t3/add-review-security-model
branch
from
October 28, 2026 19:52
c96318f to
8be073b
Compare
kmcginnes
added a commit
that referenced
this pull request
Oct 28, 2026
## Summary The access control reference didn't say what the proxy server sends back from the database, so a layer in front of it had to read the source to know which status, body, and headers reach the client. **User-facing:** none ```diff ### Reference for access control layers **Request headers.** ... +**Responses.** Status and body passed back as they arrive, error responses +included. Only `content-type` and `content-encoding` headers passed on. +Redirects not followed. **Paths.** ... ``` `docs/agents/documentation.md` now lists the forwarded response headers among the facts that section mirrors from code. ## Merge Danger **Door:** two-way **Impact:** none ## Related - Related to #2490. Once this lands, its passthrough bullet in `REVIEW.md` can cite `docs/references/security.md#reference-for-access-control-layers` instead of pointing at `fetchData`. --- <sub>🤖 Written by an AI agent on my behalf.</sub>
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security reviews keep reporting behavior that's by design, such as no built-in auth or the proxy signing with the host's shared AWS identity, because
REVIEW.mdnever pointed reviewers at the threat model indocs/references/security.md.User-facing: none
The section points at the doc instead of copying its by-design list, so the two can't drift.
Merge Danger
Door: two-way
Impact: reviews
Changes how review agents and the PR review bot judge security findings. No code or docs outside
REVIEW.mdchange.Related
🤖 Written by an AI agent on my behalf.