Repository navigation
Log debug messages at the console debug level - #2489
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerLoggerConnector.debugwrote to the browser console through theinfopath instead ofdebug, so debug messages could not be filtered in the console like the other levels.User-facing: Debug messages now appear under the browser console's Debug level instead of Info.
public debug(message: string) { - this.#clientLogger.info(message); + this.#clientLogger.debug(message); return this.#sendLog("debug", message); }The request to
POST /loggeralready carriedlevel: "debug"after Send client logs to /logger as a JSON body (#2468), and the proxy already drops it at the defaultLOG_LEVEL=info, so the server side needs no change.Evidence
Before: a test for
debugexpectinglogger.debugfailed, because the call landed onlogger.log.After: a five-row
test.eachpins both the console method and the/loggerlevel forerror,warn,info,debugandtrace, and passes.Verified live: ran the app against the proxy;
debugprinted at the console Debug level and was dropped by the server atLOG_LEVEL=info, whileinfostill printed.Merge Danger
Door: two-way
Impact: negligible
Related
🤖 Written by an AI agent on my behalf.