Repository navigation
Conversation
stobrien89
requested changes
Oct 14, 2026
stobrien89
left a comment
Member
There was a problem hiding this comment.
Looks good except for Aws\Retry\Configuration::__construct() still defaults to legacy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
standardthe default retry mode and removes theAWS_NEW_RETRIES_2026opt-in gate introduced in #3269. The retry behavior itself is unchanged from what the flag enabled.legacymode is still available viaAWS_RETRY_MODE=legacy,retry_mode = legacyin the shared config file, or'retries' => ['mode' => 'legacy'].AWS_NEW_RETRIES_2026is no longer read.Changes
Retry/ConfigurationProvider:DEFAULT_MODEis'standard';getDefaultMode()no longer checks the flag.ClientResolver,S3Client,StsClient,DynamoDbClient,DynamoDbStreamsClient: theOptIn::isEnabled()branches collapse to the new behavior, so standard/adaptive always useRetry\V3\RetryMiddleware.@internal, only reachable with the flag off):Retry/V3/OptIn,RetryMiddlewareV2,Retry/QuotaManager, and their tests.standard. Added a zero-config SNS test for the new default (3 attempts, 50 ms base)..changes/nextrelease/feat-retries-default.json.Testing
make build: no diff.Related
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.