Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #3374
Description of changes:
NonSeekableStreamDecodingEventStreamIterator decided
valid()from$stream->eof(), which is checked after the current event has already been parsed. Streams likeBufferStreamreport EOF as soon as the last byte is read, so the last complete event was dropped (and a single-event stream returned nothing).php://tempbodies only hit EOF on the next read, which is why the existing tests didn't catch it. Nownext()clears the current event once the stream is exhausted, andvalid()checks whether there is an event to return.Generated by AI tools, and reviewed by @lazerg.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.