Repository navigation
bugfix: read full message checksum on partial event stream reads - #3373
Merged
stobrien89 merged 2 commits intoOct 25, 2026
Merged
Conversation
stobrien89
approved these changes
Oct 17, 2026
Member
|
Looks good to me. We'll wait to merge until the current change set has been released. This applies to the other PRs you opened as well. |
Member
|
Thanks for the contribution @lazerg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #3371
Description of changes:
NonSeekableStreamDecodingEventStreamIterator already loops over partial reads for the headers and payload since #3165, but it still read the 4-byte message checksum with a single
read(4). When the stream hands those bytes back across more than one read, the comparison runs against a truncated checksum and a valid event fails with "Message checksum mismatch." This reads the checksum in a loop until all 4 bytes arrive or the stream ends. The new test runs the existing event-stream cases with reads capped at 1 byte.Generated by AI tools, and reviewed by @lazerg.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.