Repository navigation
Conversation
|
I haven't changed the javadoc to match the implementation, as it seems that a first review is likely to have an opinion as to API changes |
71e89a8 to
909e2a9
Compare
|
Hi |
|
I've approved the CI to run but looks like this is a breaking change. Let's wait for the CI results. |
|
@ShubhamChaturvedi7 thanks. The CI failures loom to me to be unrelated to my change - failing in I had hoped that this would not be a breaking change. It only changes non public fields and internal classes, but I dont know the threshold for breaking changes for this library! Happy to work with you or someone else to lessen the breaks which reducing the CPU cost, Please advise of the best next steps |
|
Hi @ShubhamChaturvedi7. The CI failures loom to me to be unrelated to my change - failing in Configure AWS Credentials I had hoped that this would not be a breaking change. It only changes non public fields and internal classes, but I dont know the threshold for breaking changes for this library! Happy to work with you or someone else to lessen the breaks which reducing the CPU cost, Please advise of the best next steps BTW I have another performance optimisation in #2175 awaiting review |
Issue #, if available:
No Issue
Description of changes:
Minimal change to avoid calls to Mac.getInstance
Call to this were only used to extract the provider, which I though would be better expressed as an enum, as there are very few MacAlgorithms in use.
In my (closed source) benchmark this call accounts for 5.6% of the CPU time taken for a decryption (a call to
AwsCrypto.decryptData), with small payloads, and thee same for encryptionI cant fully build this locally so cant run a test cycle prior to submitting this PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: