Repository navigation
fix: OTel operation and attempt events lose the original exception.type - #812
Merged
Merged
Conversation
nandanadileep
temporarily deployed
to
ai-pr-review-runtime
October 22, 2026 22:37 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
zhongkechen
reviewed
Oct 23, 2026
zhongkechen
left a comment
zhongkechen
left a comment
Contributor
There was a problem hiding this comment.
I found two cases worth covering in the shared tests: exception groups and custom exception constructors.
Add a regression for exception_from_error_object when error.type is missing or empty and the message is empty, including the plugin-level span event. Co-authored-by: Nandana Dileep <nandanadileep@users.noreply.github.com>
zhongkechen
approved these changes
Oct 27, 2026
zhongkechen
left a comment
zhongkechen
left a comment
Contributor
There was a problem hiding this comment.
Commit message was too long (>= 50). Squash merge will fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #804.
Preserve the checkpointed
exception.type,exception.message, and stack trace on OpenTelemetry operation and attempt events in both execution and invocation views. Record a plainException(message)with explicit saved attributes, avoiding imports and application exception constructors during telemetry recording or replay. This also supportsExceptionGroupandBaseExceptionGroup, whose constructors require more than a message.Shared regression tests cover built-in and unknown exception types, exception groups, constructor side effects, and replayed metadata. The execution view continues to suppress duplicate replayed operation spans.
Validation on Python 3.13.14:
hatch run dev-otel:test -q --tb=short: 796 passed, including integration tests.hatch run dev-otel:typecheck: passed (44 source files).hatch fmt --checkfrom the OTel package: passed.git diff --check: passed.AI-assisted contribution: OpenCode using Autoloops authored the initial patch; Codex implemented the review follow-up and ran the local checks above. No human review is claimed.