Skip to content

ci: run shared workflows on the CodeBuild runner - #759

Merged
zhongkechen merged 2 commits into
mainfrom
ci/codebuild-runner-shared-shells
Oct 14, 2026
Merged

zhongkechen merged 2 commits into
mainfrom
ci/codebuild-runner-shared-shells

Conversation

@wangyb-A

@wangyb-A wangyb-A commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Goal: run the shared-workflow jobs this repository calls (AI PR review, Slack notify, issue triage, stale-issue closer, OpenTelemetry conformance) on the CodeBuild-hosted runner in the Python testing account instead of the shared ubuntu-latest pool.

This completes the runner migration started in #747, which deliberately left these thin shells alone because their runs-on lives in the reusable workflows they call. Those now accept a runner input:

What changed

Shell Pin Runner
ai-pr-review.yml, issue-triage.yml, notify.yml d6b017da → d901b2f1 codebuild-github-actions-runner-${{ github.run_id }}-${{ github.run_attempt }}
stale-issue-closer.yml 48b3b434 → d901b2f1 same
opentelemetry-conformance-tests.yml a628f558 → 3542852f same, via runs_on

Every shell passes the label unconditionally. All of them run from main's workflow definition (pull_request_target, issues, release, schedule) or are already gated to same-repository PRs (opentelemetry-conformance-tests), and the AI review checks out the pull request's base revision and reads the diff as data, so no fork-authored code executes on the runner.

The pin bumps carry the intervening upstream commits: 12 on aws-durable-execution-ci (the runs-on input, the model-user scripts no longer assuming a runner account, the model environment passed as an explicit env -i allowlist, one stale-issue-closer fix, dependabot bumps) and 8 on aws-durable-execution-conformance-tests.

Draft

The CI-repo pin points at the head of aws/aws-durable-execution-ci#67's branch. When #67 merges (squash), one follow-up commit replaces it with the merge SHA; nothing else changes. Do not merge while the pin is a branch commit.

Verification

  • Every with: key each shell passes was checked against the callee's workflow_call inputs at the new pin; all resolve.
  • opentelemetry-conformance-tests is pull_request-triggered and the orchestrator change is on main, so this PR's own OTel run exercises the CodeBuild path end to end.
  • The other shells run from main's definition, so this PR cannot exercise them; the first event after merge is the live test. The reusable Codex review was run end to end on the CodeBuild runner from the Update Model to use chained invoke over invoke #67 branch in aws-durable-execution-sdk-js run 37542509461, and the model-user scripts were exercised as root in run 37539805626.
  • OTel job durations on recent PR runs are 3–8 minutes, under the project's 60-minute job limit.

no linked issue: follow-up to #747.

Alex Wang and others added 2 commits October 6, 2026 23:43
Bump the aws-durable-execution-ci and conformance-tests orchestrator pins to the commits that accept a runner input, and pass the CodeBuild runner label from every thin shell.
Keep the OTel caller identical to main. Pin the four remaining callers
to merged shared-CI code and test their CodeBuild runner labels.
@hln33
hln33 marked this pull request as ready for review October 14, 2026 16:31
@hln33
hln33 deployed to ai-pr-review-runtime October 14, 2026 16:31 — with GitHub Actions Active
@hln33
hln33 deployed to ai-pr-review-runtime October 14, 2026 16:54 — with GitHub Actions Active
@zhongkechen
zhongkechen merged commit 9a87021 into main Oct 14, 2026
31 checks passed
@zhongkechen
zhongkechen deleted the ci/codebuild-runner-shared-shells branch October 14, 2026 17:14
@github-actions

Copy link
Copy Markdown
Contributor

Codex AI review

No actionable findings. Residual risk: the YAML test cannot exercise live invocation of the externally pinned reusable workflows.

Reviewed commit 55b31a915f6dfcd024d4f55a9ca075ac3263e26c. Workflow run

This branch was successfully deployed

1 active deployment
ai-pr-review-runtime — 55b31a91 Deployed Oct 14, 2026 by hln33 via ai-pr-review / Codex review / Generate Codex review #1673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants