Repository navigation
fix(sdk): skip plugin hook work without plugins - #796
Merged
Merged
Conversation
When a checkpoint response changed an operation's status, onCheckpointComplete converted every stored operation for the operation change hook, even when no plugin was registered. So the cost of each checkpoint grew with the number of operations, and long sequential executions slowed down as they ran. onCheckpointComplete now builds the change info and calls onOperationChange only when a plugin is registered. Plugins receive the same information as before. Fixes #795
Contributor
Codex AI reviewNo actionable findings. The guard preserves checkpoint updates and registered-plugin notifications, with focused regression tests for both paths. Residual test risk: tests were inspected but not executed, as required by the review constraints. Reviewed commit |
zhongkechen
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Fixes #795
Description
When a checkpoint response changed an operation's status, onCheckpointComplete converted every stored operation for the operation change hook, even when no plugin was registered. So the cost of each checkpoint grew with the number of operations, and long sequential executions slowed down as they ran.
onCheckpointComplete now builds the change info and calls onOperationChange only when a plugin is registered. Plugins receive the same information as before.
Demo/Screenshots
Not applicable.
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Yes. ExecutionManagerTest has two new tests.
Integration Tests
Have integration tests been written for these changes?
No. The unit tests cover both paths. The existing onOperationChange tests in PluginIntegrationTest pass unchanged.
Examples
Has a new example been added for the change? (if applicable)
No. The change does not affect the public API.