Repository navigation
docs(otel): clarify invocation header failure handling - #765
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 of 4 tasks
zhongkechen
changed the title
This comment has been minimized.
This comment has been minimized.
zhongkechen
changed the title
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 5, 2026 23:27 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
10 tasks
This comment has been minimized.
This comment has been minimized.
zhongkechen
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zhongkechen
changed the title
This comment has been minimized.
This comment has been minimized.
nvasiu
reviewed
Oct 21, 2026
Contributor
Codex AI reviewNo actionable findings. The documentation-only changes match the existing implementation and test coverage. Tests were inspected but not executed, so runtime validation remains unverified. Reviewed commit |
nvasiu
approved these changes
Oct 21, 2026
This was referenced Oct 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link, if available
Related to #762. The runtime carrier implementation and factory-compatible coverage are included in merged #782.
Description
The README explains empty and malformed invocation headers but omits the available-accessor failure path and capture behavior without plugins. Clarify that a nonfatal accessor failure is authoritative absence, that capture is skipped without registered factories, and name the four recognized wrapper classes whose JVM-fatal causes retain their identity. Identify the eight-component InvocationInfo record as part of 3.x.
The remaining diff is documentation only. The current
3.0.0runtime, per-invocation factories, X-Ray implementation, and tests are the exact versions already on main atac4c0638.Testing
git diff --checkpassed. The statements were checked against RuntimeTraceHeader and the existing RuntimeHeaderFailureIntegrationTest / InvocationInfoHeaderIntegrationTest coverage. No runtime, test, POM, or workflow files differ from merged main, so unchanged unit suites were not repeated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.