Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conformance-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
</parent>

<artifactId>aws-durable-execution-sdk-java-conformance-tests</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion coverage-report/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
</parent>

<artifactId>aws-durable-execution-sdk-java-coverage-report</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion examples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
</parent>

<artifactId>aws-durable-execution-sdk-java-examples</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion insight-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
</parent>

<artifactId>aws-durable-execution-sdk-java-plugin-insight</artifactId>
Expand Down
8 changes: 4 additions & 4 deletions otel-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ still reports `FAILED` when its error response can be serialized. This provides
not a fixed depth or time limit. Arbitrary custom `getCause`, other `Throwable` accessors, and customer `SerDes`
behavior remain outside that guarantee.

This plugin version requires the core's `DurableExecutor.supportsSameThreadInvocationHooks()` capability, introduced
in the 2.2.2 lifecycle contract (currently `2.2.2-SNAPSHOT`). Upgrade the core together with the plugin layer. Every
plugin constructor checks this capability before building a tracer provider or activating context. A core without
it, including released 2.2.1, is rejected with an explicit configuration error. Older cores may call
This plugin version requires the core's `DurableExecutor.supportsSameThreadInvocationHooks()` capability.
Upgrade the core together with the plugin layer. Every plugin constructor checks this capability before building a
tracer provider or activating context. A core without it, including released 2.2.1, is rejected with an explicit
configuration error. Older cores may call
`onInvocationEnd` on another thread and are not supported with this plugin version. Existing plugin binaries remain
usable with the updated core; their invocation-end hooks now follow the same-thread, reverse-registration-order
contract described above.
Expand Down
2 changes: 1 addition & 1 deletion otel-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
Comment thread
zhongkechen marked this conversation as resolved.
Comment thread
zhongkechen marked this conversation as resolved.

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do a sweep through to see if there are any other inconsistencies

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the sweep and updated this PR in 685db0ef. All nine reactor POMs, parent references and internal module dependencies agree on 2.3.0. I inspected the four freshly built release JARs: their Maven metadata is 2.3.0, the SDK version resource is 2.3.0, and the OTel diagnostic contains the corrected wording.

The sweep found stale 2.2.2 lifecycle-version references in the OTel README, configuration diagnostic and core Javadoc. Those now describe the actual same-thread capability, preserving the capability check and the instruction to upgrade core and plugin together. Intentional references to released 2.2.1 and old compatibility fixtures remain.

The latest external main merge is preserved, and the formatting-only repair from #794 is included. A fresh Java 17 spotless:check package -DskipTests passed; tests were intentionally skipped for this packaging check, and new-head CI remains separate. The description now reflects the guidance changes and retains the remaining release prerequisites and final validation gates.

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 685db0ef. Removed the obsolete 2.2.2 release claim from the README, configuration diagnostic and core Javadoc. The check still requires DurableExecutor.supportsSameThreadInvocationHooks(), and the documentation still requires upgrading core and plugin together. The built 2.3.0 OTel JAR contains the corrected diagnostic; intentionally historical 2.2.1 references are retained.

</parent>

<artifactId>aws-durable-execution-sdk-java-plugin-otel</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static void runInvocationEnd(Scope scope, Runnable end) {
/** Rejects an older core before a plugin builds a provider or activates thread-local context. */
static void requireSameThreadInvocationHooks() {
var message = "This OpenTelemetry plugin requires same-thread invocation hooks from the Durable Execution"
+ " core (2.2.2 lifecycle capability). Upgrade the core together with the plugin layer.";
+ " core. Upgrade the core together with the plugin layer.";
try {
if (!DurableExecutor.supportsSameThreadInvocationHooks()) throw new IllegalStateException(message);
} catch (NoSuchMethodError missingCapability) {
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
<packaging>pom</packaging>

<name>AWS Lambda Durable Execution SDK</name>
Expand Down
2 changes: 1 addition & 1 deletion sdk-integration-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
</parent>

<artifactId>aws-durable-execution-sdk-java-integration-tests</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion sdk-testing/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
</parent>

<artifactId>aws-durable-execution-sdk-java-testing</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion sdk/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>software.amazon.lambda.durable</groupId>
<artifactId>aws-durable-execution-sdk-java-parent</artifactId>
<version>2.2.2-SNAPSHOT</version>
<version>2.3.0</version>
</parent>

<artifactId>aws-durable-execution-sdk-java</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,8 +498,8 @@ public Builder withCheckpointEmptyMap(boolean checkpointEmptyMap) {
* their existing registration behavior.
*
* <p>Calling this method replaces any previously registered plugins. Hooks use registration order, except
* invocation end, which uses reverse order under the 2.2.2 same-thread lifecycle contract. A fresh builder
* combines this explicit list with environment-selected plugins. On a builder returned by
* invocation end, which uses reverse order under the same-thread lifecycle contract. A fresh builder combines
* this explicit list with environment-selected plugins. On a builder returned by
* {@link DurableConfig#toBuilder()}, this method replaces the complete resolved list and dynamic discovery
* remains disabled, including when the replacement list is empty.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ private DurableExecutor() {}
/**
* Returns whether this core runs invocation start/end hooks on the root handler thread and awaits handler cleanup
* and end-hook completion before returning. Plugins that retain thread-local scopes may require this capability
* before construction. Introduced with the 2.2.2 lifecycle contract.
* before construction.
*/
public static boolean supportsSameThreadInvocationHooks() {
return true;
Expand Down
Loading