Repository navigation
feat(cli): support global AWS profile selection - #2701
Open
proton0210 wants to merge 1 commit into
Open
proton0210 wants to merge 1 commit into
proton0210 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a global
--profileflag so commands such asagentcore deploy --profile developmentselect the named AWS shared configuration profile. Profile credentials override ambient static keys, while explicit target credentials remain authoritative. Region precedence remains--region, environment, selected profile, then the default.Selection is scoped to the command's asynchronous work. SDK client caches, deployment credentials, STS account lookup, Bedrock Agent import, child tools, and local containers receive the selection without changing the parent environment. Container development mounts explicitly configured shared files read-only. Telemetry uses the selected profile's region for its China-region gate. README examples and the generated command reference are included.
Child tools still need to support the profile's authentication mechanism in their own runtime; a host-specific
credential_processexecutable is not copied into containers.Related Issue
Closes #1727
Documentation PR
Documentation is included here.
Type of Change
Testing
bun test: 4,730 passed, five Windows-only tests skipped on macOS; six snapshots passed.bun run typecheckbun run lint:checkbun run format:checkbun run buildbun run secrets:checkbun install --frozen-lockfileRegression coverage includes concurrent and nested command scopes, selected-profile client caching, explicit target credentials, STS signing, assume-role region selection,
credential_processsession credentials, subprocess environment isolation, custom container configuration files, empty profile validation, and China-region telemetry suppression.bun run auditreports nine advisories already present in the dependency tree (one high, four moderate, four low). This change declares the already-locked credential provider as a direct dependency and does not change resolved dependency versions.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.