Repository navigation
Enhancement suggestion: correlation id middleware combined with logger and sampler #9
Description
Hello Heitor,
Have you considered adding a correlation_id middleware like the one in DAZN power tools?
It could work together with the logger tool by adding correlation_id to the logs automatically, and also be used by the sampling feature (the whole transaction is sampled instead of each function invoke).
Regards,
Marcio.
Activity
heitorlessa commentedon Mar 19, 2020
Hey Marcio,
I did considered though I haven't been able to create a design document to flesh this out yet.
I'm currently working on another project until mid April, but if that's something you'd like to kick off I'd be super happy to contribute.
Thanks a lot for reaching out
marcioemiranda commentedon Mar 24, 2020
Hello Heitor,
I would like to contribute if you give me some pointers.
Regards,
Marcio
heitorlessa commentedon Mar 25, 2020
Absolutely @marcioemiranda - Here's a breakdown of how the logger works
key=valueargument that will be present across all log operationsI see two ways of implementing it:
I personally prefer B as it's more extensible since we could also use the correlation ID data in Tracer to create an annotation, and in future modules like detecting retries, etc.
Regardless of the option, it'll have to add a new key
correlation_idin this line: https://github.com/awslabs/aws-lambda-powertools/blob/develop/python/aws_lambda_powertools/logging/logger.py#L149Happy to explain further but hopefully that makes sense
heitorlessa commentedon May 12, 2020
I've decided to look at this after GA - Logger can append additional keys, and custom middlewares can be created now.
I want to spend more time in the design phase to make this scalable to multiple event sources too. I'll ping here when I start working on a design to get your ideas too.
keithrozario commentedon Jul 30, 2020
This would be an awesome feature, and would be super useful for many folks.
patrickwerz commentedon Oct 9, 2020
yes, definitely interested.
heitorlessa commentedon Jan 15, 2021
Couldn't spend much quality time to think about the developer experience yet -- If anyone has the bandwidth, I'd appreciate a RFC for further discussion here.
michaelbrewer commentedon Mar 9, 2021
Yes, this would be super useful. I will see if i have the headspace for this :)
michaelbrewer commentedon Mar 9, 2021
I created a demo PR here:
michaelbrewer commentedon Mar 10, 2021
FYI @marcioemiranda @patrickwerz @keithrozario the PR was merged for the first part of this.