Skip to content

compat-check: replace board-name heuristic with explicit ignore list #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicksinas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compat-check: replace board-name heuristic with explicit ignore list #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions scripts/lib/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,16 @@ _fetch() {
# enumerate targets for supported_targets: '*').
# rc 0 + output = published list; rc 0 + empty = feed absent (404);
# rc 1 = could not determine (fetch/parse error) — abort, don't skip.
# ponytail: 2024/edge also lists tune/arch keys (cortexa53, x86_64_v2, noarch,
# qcm6490 SoC); they are filtered by NON_BOARD_RE. Boards never use '_'.
NON_BOARD_RE='_|^noarch$|^qcm[0-9]+$'
# Permanent ignore: keys that appear in targets.json but are platforms/tunes,
# not buildable targets (there is no avocado-sdk-<name> for them; all seen in
# 2024/edge). This explicit list is the only filter — anything new that is not
# a real target fails loudly at install and gets added here. icam-540 is a
# *board* of jetson-orin-nx and is still built as one via feed_boards; it is
# only ignored as a top-level target key.
IGNORE_TARGETS="armv8_2a armv8a armv8a_tegra armv8a_tegra234 core2_64
cortexa53 cortexa53_crypto cortexa53_crypto_mx8mp cortexa55 cortexa55_mx91 cortexa55_mx93
cortexa57 cortexa72 cortexa73 cortexa76 x86_64_v2 x86_64_v3
noarch qcm6490 icam-540"
feed_targets() {
local tmp rc
tmp="$(mktemp)"
Expand All @@ -172,7 +179,7 @@ feed_targets() {
if ! jq -e 'type == "object"' "$tmp" >/dev/null 2>&1; then
rm -f "$tmp"; echo " ❌ targets.json for $1/$2 is not valid JSON" >&2; return 1
fi
jq -r 'keys[]' "$tmp" | grep -vE "$NON_BOARD_RE" | sort
jq -r 'keys[]' "$tmp" | grep -vxF -f <(printf '%s\n' "$IGNORE_TARGETS" | tr ' ' '\n' | grep .) | sort
rm -f "$tmp"
return 0
}
Expand Down
Loading