Repository navigation
Repair mixed xunit pins: bump xunit group to 4.0.2 and xunit.analyzers to 2.2.0 - #299
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the mixed xUnit pins on
mainand brings every xUnit v3 package to 4.0.2.mainis currently broken on its own, independently of any open PR. The pins are inconsistent:xunit.v3.mtp-v2,xunit.v3.core.mtp-v2andxunit.v3.runner.inproc.consolesit at 4.0.0 while the rest are at 4.0.1. Sincexunit.v3.core.mtp-v24.0.0 requiresxunit.v3.extensibility.core (= 4.0.0)exactly, restore fails, andNU1608is escalated to an error byWarningConfiguration.targets. Reproduced on a clean clone ofmain:The same error occurs for
xunit.v3.runner.inproc.console4.0.0. This is why the scheduled CI Build onmainhas been failing. #298 changes some of these pins but not all, so it does not resolve the inconsistency.Changes
Directory.Packages.propsonly, plus the regenerated lock file:xunit.analyzers2.1.0 -> 2.2.0xunit.v3.core.mtp-v2,xunit.v3.runner.inproc.console,xunit.v3.mtp-v24.0.0 -> 4.0.2xunit.v3.assert,xunit.v3.common,xunit.v3.extensibility.core,xunit.v3.runner.common4.0.1 -> 4.0.2VerifyandVerify.XUnitV3stay at 31.9.0. They are already consistent with each other, andVerify.XUnitV331.9.0 depends onxunit.v3.extensibility.core 3.2.1as a minimum, which 4.0.2 satisfies.Lock file regenerated with
dotnet restore --force-evaluate.Validation
Run locally with this repo's CI commands:
CI=true dotnet restore --nologopasses, where the same command fails onmaindotnet build --no-restore --nologo --configuration Release: 0 warnings, 0 errorsdotnet test --no-build --configuration Release: 9 total, 9 passed, across net8.0, net9.0 and net10.0dotnet format --no-restore --verify-no-changes -v diag: cleanNo Verify snapshot files changed.
Follow-up
.github/updater.ymlsetstargetFramework: netstandard2.0, which matches the generator project but not the test project (net8.0;net9.0;net10.0). The xUnit packages are only used by the test project. This mismatch is why the bot never updatedxunit.v3.mtp-v2,xunit.v3.core.mtp-v2andxunit.v3.runner.inproc.console: their dependency groups only cover net472 and net8.0, neither of which a netstandard2.0 consumer can use, so they were silently skipped. Left unchanged here; it needs a decision about whether the updater should infer per-project target frameworks instead of taking one value from config.Note
The commit is unsigned because the 1Password SSH agent was unavailable on the machine that produced it.