Repository navigation
fix: reject tokens that are not yet valid and avoid reusing near-expiry cached tokens - #149
Merged
Merged
Conversation
nandan-bhat
reviewed
Oct 23, 2026
Adds tests for the exact 30 second buffer and the nbf equal and fractional cases. Lists nbf in the verify_access_token docstring and notes that tokens with expires_in of 30 or less are never served from the cache.
nandan-bhat
approved these changes
Oct 23, 2026
3 of 6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR makes
verify_access_token()reject tokens that are not valid yet, and stops the token caches from handing back a token that is about to expire.🐛 Bug Fixes
nbfCheck:verify_access_token()rejects a token whosenbfclaim is in the future. A token withoutnbfis still accepted, and a non-numericnbfraisesVerifyAccessTokenError.expires_inof 30 seconds or less is never served from the cache. This applies to On Behalf Of, client credentials and Token Vault tokens, including the scope-matching index.🔧 API Changes
verify_access_token()now raisesVerifyAccessTokenErrorwith the message "Token is not yet valid" whennbfis in the future. It previously accepted such a token.📖 Documentation
docs/TokenStorage.md🧪 Testing
Contributor Checklist