Repository navigation
Conversation
Larocceau
force-pushed
the
feature/fix-esptool-warnings
branch
from
October 21, 2026 19:42
341fa2d to
3a633d3
Compare
Signed-off-by: Larocceau <larocceau@gmail.com> Signed-off-by: larocceau <larocceau@users.noreply.github.com>
Larocceau
force-pushed
the
feature/fix-esptool-warnings
branch
from
October 21, 2026 19:43
3a633d3 to
064ffb9
Compare
bettio
reviewed
Oct 26, 2026
bettio
left a comment
bettio
left a comment
Collaborator
There was a problem hiding this comment.
It looks good, do you mind to rebase it (using git rebase) on top of release-0.7 and to target that branch instead of main?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for taking the time to review my PR!
While running the initial setup using the readme, I got the following 2 warnings: