Repository navigation
Preserve grid data rows across separating lines - #509
Open
OnlineBunker wants to merge 2 commits into
Open
OnlineBunker wants to merge 2 commits into
OnlineBunker wants to merge 2 commits into
Conversation
Keep data rows and vertical alignments when separators are reinserted. AI-assisted implementation and tests.
Add 34 regression/control cases across grid formats. AI-assisted tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #508.
Grid formatting zipped a row list containing reinserted separators with a shorter data-row alignment list. Multiple separators could silently omit data rows and shift vertical alignments. Iterate every row and consume an alignment only for data rows, preserving the existing separator rules.
Added 34 regression/control cases across grid, fancy_grid and rounded_grid: leading/trailing/consecutive separators, exact output and multiline row alignment. Twenty-eight fail on unchanged master; six are controls.
Validation on Linux Python 3.10, 3.11, 3.12, 3.13 and 3.14: 416 passed, 1 skipped on each, including library/README doctests and NumPy/pandas/wcwidth tests. Full Ruff checks and changed-file formatting checks pass. Both submitted files were read back from the branch, matched to the tested content, and retested in a separate directory (416 passed, 1 skipped). Inspected rendered before/after tables and multiline alignment. Other operating systems not tested.
This changes only the grid iteration branch, not #452's separate nongrid alignment work or #465/#470's index validation.
AI-assisted implementation and tests.