Repository navigation
chore: share bazelrc setup across e2e workspaces - #217
Merged
Merged
Conversation
This change moves duplicated bazelrc logic out of e2e workspaces and into a shared file `tools/e2e.bazelrc`. The `%workspace%` references in bazelrc files always represent the root of the invoking workspace, so we can only share logic across workspaces at the same depth in the repo. This prevents us from having the root bazelrc use the same shared file. I also switched from `try-import` to just `import` for `.aspect/bazelrc`, because I don't think there is any realistic situation where we would need to gracefully handle that file being absent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Aspect Workflows Tasks📅 Tue Sep 22 21:13:13 UTC 2026 Task Results
⏱ Last updated Tue Sep 22 21:15:00 UTC 2026 · 📊 GitHub API quota 760/7,700 (10% used, resets in 50m) |
acozzette
marked this pull request as ready for review
September 22, 2026 21:15
jbedard
reviewed
Sep 22, 2026
jbedard
reviewed
Sep 22, 2026
jbedard
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves duplicated bazelrc logic out of e2e workspaces and into a shared file
tools/e2e.bazelrc. The%workspace%references in bazelrc files always represent the root of the invoking workspace, so we can only share logic across workspaces at the same depth in the repo. This prevents us from having the root bazelrc use the same shared file.I also switched from
try-importto justimportfor.aspect/bazelrc, because I don't think there is any realistic situation where we would need to gracefully handle that file being absent.Changes are visible to end-users: no
Test plan