Skip to content

fix: pass --lockfile_mode=off to internal bazel info probes - #1562

Merged
jeffpignataro merged 2 commits into
mainfrom
thesayyn/charming-faraday-ccr9cl
Oct 19, 2026
Merged

jeffpignataro merged 2 commits into
mainfrom
thesayyn/charming-faraday-ccr9cl

Conversation

@thesayyn

@thesayyn thesayyn commented Oct 8, 2026

Copy link
Copy Markdown
Member

Adds --lockfile_mode=off after info in the internal probe commands (check_bazel_server, get_output_base, server_info_with_startup_flags, client_pid, is_server_busy, server_pid_nonblocking) so a reused Bazel 8 server can't rewrite MODULE.bazel.lock.

Fixes #1561

🤖 Generated with Claude Code

https://claude.ai/code/session_01TwhYhtbtbN5H2FtZ9qUjpD


Generated by Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@CLAassistant

CLAassistant commented Oct 8, 2026 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jeffpignataro
❌ claude
You have signed the CLA already but the status is still pending? Let us recheck it.

@aspect-workflows

aspect-workflows Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Aspect Workflows Tasks

Task Results


Install aspect: aspect.build/docs/cli/install · Powered by Aspect CLI (v0.0.0-dev)

@jeffpignataro
jeffpignataro enabled auto-merge (squash) October 19, 2026 16:07

Copy link
Copy Markdown
Member Author

aspect / init-shell failed on 7f16872, but not because of this change: the build died fetching the ape toolchain (https://cosmo.zip/pub/cosmos/v/4.0.2/bin/ape-x86_64.elf and assimilate, "Connect timed out"), which aborted analysis of //tools:bazel_env. Nothing in this diff touches that. The same job passed on the previous head (8140724). No fix is needed on the PR; I'll re-run the failed job once the rest of the workflow run finishes.


Generated by Claude Code

@jeffpignataro

Copy link
Copy Markdown
Collaborator

aspect / init-shell failed on 7f16872, but not because of this change: the build died fetching the ape toolchain (https://cosmo.zip/pub/cosmos/v/4.0.2/bin/ape-x86_64.elf and assimilate, "Connect timed out"), which aborted analysis of //tools:bazel_env. Nothing in this diff touches that. The same job passed on the previous head (8140724). No fix is needed on the PR; I'll re-run the failed job once the rest of the workflow run finishes.

Generated by Claude Code

We have a GH incident at the moment. I think it's related since I'm seeing several PRs failing CI checks.

Copy link
Copy Markdown
Member Author

Update on the init-shell / init-preset (shell) failure: attempt 2 (re-run) failed identically at 16:49Z. https://cosmo.zip/pub/cosmos/v/4.0.2/bin/assimilate and ape-x86_64.elf still hit "Connect timed out", which aborts analysis of //tools:bazel_env. Every other job passed on attempt 2 (42/42), so this is the only thing keeping ci-ok red.

So this looks like cosmo.zip being unreachable from the runners rather than a transient GitHub blip, and it is unrelated to the --lockfile_mode=off changes. Re-running will keep failing until that host is reachable again (or the ape toolchain download is mirrored or cached). I'm not changing anything in this PR for it.


Generated by Claude Code

@gregmagolan
gregmagolan force-pushed the thesayyn/charming-faraday-ccr9cl branch from 7f16872 to 8b3db86 Compare October 19, 2026 17:02
claude and others added 2 commits October 19, 2026 12:39
Fixes #1561

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TwhYhtbtbN5H2FtZ9qUjpD
The aspect materializer's `bazel info install_base` probe was missed by
the earlier change; give it the same flag so it cannot rewrite
MODULE.bazel.lock either.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013uQ5fDkcwzTosokxPggJWk
@gregmagolan
gregmagolan force-pushed the thesayyn/charming-faraday-ccr9cl branch from 9dadffe to 0f7ce7a Compare October 19, 2026 19:39
@jeffpignataro
jeffpignataro merged commit 66298af into main Oct 19, 2026
72 of 73 checks passed
@jeffpignataro
jeffpignataro deleted the thesayyn/charming-faraday-ccr9cl branch October 19, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make internal bazel info probes read-only with --lockfile_mode=off

5 participants