Repository navigation
NOJIRA: support an optional seed on percent conditions - #10
Merged
Merged
Conversation
Add an optional `seed` argument to ConditionBuilder.PERCENT().GT()/.LTE()/
.BETWEEN(), threaded into PercentCondition so percent conditions can pin the
hashing seed (renders as `percent('seed') <op> N`). Omitting it keeps the
default per-project randomization.
Validate PercentCondition.seed against Firebase's constraint (0-32 characters
from [-_.0-9a-zA-Z]) so a malformed seed is rejected before reaching the API.
Bump version to 0.3.0 and add a changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seedargument toConditionBuilder.PERCENT().GT()/.LTE()/.BETWEEN(), threaded intoPercentConditionso percent conditions can pin the hashing seed. Renders aspercent('seed') <op> N, matching Firebase Remote Config's condition-expression syntax; omitting it keeps the default per-project randomization.PercentCondition.seedagainst Firebase's constraint (0-32 characters from[-_.0-9a-zA-Z]), so a malformed seed is rejected up front instead of by the Remote Config API.0.3.0and add aCHANGELOG.mdentry.