fix(crawlers): Decode non-UTF-8 pages correctly in ParselCrawler and BeautifulSoupCrawler - #2260
Merged
Merged
Conversation
…tifulSoupParser`
Mantisus
force-pushed
the
fix-parsel-encoding
branch
from
September 28, 2026 18:39
4cebb21 to
0bb9396
Compare
vdusek
changed the title
ParselParser and BeautifulSoupParser
vdusek
approved these changes
Sep 29, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks! I just pushed a few minor follow-up commits.
Pijukatel
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ParselParserdecoded every response as UTF-8, so pages in other encodings came out garbled inParselCrawler,AdaptivePlaywrightCrawlerandPydanticAiCrawler.BeautifulSoupParserignored theContent-Typecharset and returned an empty soup for a page with a<meta>charset and a single invalid byte.Both parsers now decode the page with the encoding it declares: the BOM, then the
Content-Typecharset, then an XML declaration or<meta>tag. Labels are resolved per the WHATWG Encoding Standard, as browsers do, so e.g.ISO-8859-1is read aswindows-1252, and unknown labels are ignored.If the page declares no encoding, each parser falls back to its default behaviour:
BeautifulSoupParserdetects the encoding itself andParselParserreads the page as UTF-8.Testing
✍️ Drafted by Claude Code