Conversation
vdusek
added this pull request to stack #1152
September 30, 2026 09:49
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/abort-child-runs-with-parent #1154 +/- ##
=====================================================================
+ Coverage 93.21% 93.29% +0.08%
=====================================================================
Files 54 54
Lines 3728 3804 +76
=====================================================================
+ Hits 3475 3549 +74
- Misses 253 255 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was
linked to
issues
Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1153.
Adds
Actor.set_child_run_limits(max_concurrent_runs=...). While that many named child runs areREADY,RUNNING,ABORTINGorTIMING-OUT, a namedActor.startorActor.callthat would start or resurrect a run waits for one of them to finish. Reattaching to a recorded run never waits, and runs without anamearen't counted.The count comes from the child run registry, so children started before a migration hold their slots too. A child's status is fetched again before counting once it's more than 10 seconds old, so a finished run nobody waited on frees its slot.
Actor.callfrees the slot as soon as its run finishes. A start holds its slot until the run is recorded, which keeps concurrent starts under different names within the limit.The limit lives in memory, so the Actor sets it again after a migration. Once the parent receives
ABORTING, a start still waiting for a slot raises aRuntimeErrorwithout starting a run. Waiting further would block the abort of the other children.Closes #1138
✍️ Drafted by Claude Code