Skip to content

Fix duplicate role key in committee roster JSON #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebbASF merged 1 commit into from
Oct 14, 2026
Merged

Fix duplicate role key in committee roster JSON #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion www/roster/models/committee.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def self.serialize(id, env)
roster.each {|k, v| v[:member] = ASF::Person.find(k).asf_member?}

if pmc.chair and roster[pmc.chair.id]
roster[pmc.chair.id]['role'] = 'PMC chair'
roster[pmc.chair.id][:role] = 'PMC chair'
end

# separate out the known ASF members and extract any matching committer details
Expand Down
2 changes: 1 addition & 1 deletion www/roster/models/nonpmc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def self.serialize(id, env)
end

if cttee.chair and roster[cttee.chair.id]
roster[cttee.chair.id]['role'] = 'Committee chair'
roster[cttee.chair.id][:role] = 'Committee chair'
end

# separate out the known ASF members and extract any matching committer details
Expand Down
Loading