Skip to content

Change postal to residence to agree with ICLA form #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebbASF merged 2 commits into from
Sep 17, 2026
Merged

Change postal to residence to agree with ICLA form #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5730258
Update incomplete.json.rb
clr-apache Sep 16, 2026
6d65d78
Update parts.js.rb
clr-apache Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions www/secretary/workbench/views/actions/incomplete.json.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@

# The keys below must agree with the checkbox names in parts.js.rb
REASONS = {
'@missing_address' => 'missing or incomplete postal address (must include street, building, unit/apartment)',
'@missing_address' => 'missing or incomplete residence address (must include street, building, unit/apartment)',
'@missing_email' => 'missing email address',
'@wrong_email' => 'email address shown in the ICLA must agree with the sender',
'@corporate_postal' => 'the postal address does not appear to be a personal residence address',
'@corporate_residence' => 'the residence address does not appear to be a personal residence address',
'@invalid_public' => 'the public name should be a real name or pen name and not a user id',
'@invalid_name' => 'as this is a legal document, your full legal name is required',
'@invalid_language' => 'the form must contain only English',
Expand Down
10 changes: 5 additions & 5 deletions www/secretary/workbench/views/parts.js.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def initialize
@missing_address = false
@missing_email = false
@wrong_email = false
@corporate_postal = false
@corporate_residence = false
@invalid_public = false
@invalid_name = false
@invalid_language = false
Expand Down Expand Up @@ -213,7 +213,7 @@ def render
_input type: 'hidden', name: 'missing_address', value: @missing_address
_input type: 'hidden', name: 'missing_email', value: @missing_email
_input type: 'hidden', name: 'wrong_email', value: @wrong_email
_input type: 'hidden', name: 'corporate_postal', value: @corporate_postal
_input type: 'hidden', name: 'corporate_residence', value: @corporate_residence
_input type: 'hidden', name: 'invalid_public', value: @invalid_public
_input type: 'hidden', name: 'invalid_name', value: @invalid_name
_input type: 'hidden', name: 'invalid_language', value: @invalid_language
Expand Down Expand Up @@ -302,9 +302,9 @@ def render
end
_li do
_label do
_input type: 'checkbox', checked: @corporate_postal,
onClick: -> {@corporate_postal = !@corporate_postal}
_span ' corporate postal address'
_input type: 'checkbox', checked: @corporate_residence,
onClick: -> {@corporate_residence = !@corporate_residence}
_span ' corporate residence address'
end
end
_li do
Expand Down