Skip to content

Update parts.js.rb #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clr-apache merged 2 commits into from
Sep 14, 2026
Merged

Update parts.js.rb #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63bc996
Update parts.js.rb
clr-apache Sep 14, 2026
796fdc4
Update incomplete.json.rb
clr-apache Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions www/secretary/workbench/views/actions/incomplete.json.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
'@unsigned' => 'the document appears to be unsigned',
'@script_font' => 'a name typed in a script font is not a signature',
'@undated' => 'the document must have a date next to the signature',
'@grant_missing' => 'a Software Grant Agreement must have Exhibit A filled',
}
# These aren't reasons for rejection, but need to be fixed
OTHERS = {
Expand Down
9 changes: 9 additions & 0 deletions www/secretary/workbench/views/parts.js.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def initialize
@upload_sig = false
@invalid_availid = false
@undated = false
@grant_missing = false
end

########################################################################
Expand Down Expand Up @@ -228,6 +229,7 @@ def render
_input type: 'hidden', name: 'unsigned', value: @unsigned
_input type: 'hidden', name: 'script_font', value: @script_font
_input type: 'hidden', name: 'undated', value: @undated
_input type: 'hidden', name: 'grant_missing', value: @grant_missing
_input type: 'hidden', name: 'upload_sig', value: @upload_sig
_input type: 'hidden', name: 'invalid_availid', value: @invalid_availid
# the above entries must agree with the checked: entries below
Expand Down Expand Up @@ -410,6 +412,13 @@ def render
_span ' undated'
end
end
_li do
_label do
_input type: 'checkbox', checked: @grant_missing,
onClick: -> {@grant_missing = !@grant_missing}
_span ' grant missing'
end
end
_li do
_label do
_input type: 'checkbox', checked: @upload_sig,
Expand Down