Repository navigation
Expand the File Format sidebar only on its own pages - #1041
Merged
Merged
Conversation
The groups were pinned open with expanded: true, which also opened them on unrelated pages. The prefix already marks them active on their index pages, so drop the flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The File Format and Data Pages sidebar groups were configured with
expanded: true. That flag pins a group open whenever it is rendered, so the File Format tree also appeared expanded on unrelated pages such as QuickStart.Fix
Drop
expanded: truefrom both groups in the English and Chinese sidebars. Theirprefixalready marks them active on their own index pages, which is what keeps them open there:/UserGuide/latest/FileFormat/— the File Format group stays open./UserGuide/latest/FileFormat/DataPages/— both groups stay open.On any other page they now stay collapsed like the rest of the sidebar.
Test plan
pnpm docs:build