Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several conditions suppress substantial locale-independent parser coverage instead of isolating only the affected date assertions.
4 open findings
What changed in this PR
Improves nightly locale testing by aggregating failures and addressing locale-sensitive tests.
Changes:
- Adds non-Gregorian calendar detection and tests.
- Adjusts locale-sensitive parser tests and date formatting.
- Aggregates Surefire/Failsafe failures after the Maven reactor completes.
| File | Description |
|---|---|
tika-test-support/.../TestLocales.java |
Adds calendar-type detection. |
tika-core/.../TestLocalesTest.java |
Tests locale classification. |
.../ZipEntryTimesTest.java |
Handles non-Gregorian ZIP behavior. |
.../ZipDosTimeDstTest.java |
Disables locale-sensitive DOS-time tests. |
.../RarParserTest.java |
Handles junrar date behavior. |
.../OutlookParserTest.java |
Handles POI MAPI date behavior. |
.../MailDateParserTest.java |
Uses locale-stable date formats. |
.../FontParsersTest.java |
Handles FontBox date behavior. |
.../TabularFormatsTest.java |
Pins locale during tabular tests. |
.github/workflows/nightly-locale-build.yml |
Collects all test failures before failing. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| @Test | ||
| // fontbox TTFDataStream.readInternationalDate builds its Calendar in the default locale (TIKA-4920) | ||
| @DisabledIf("org.apache.tika.test.TestLocales#nonGregorianDefault") |
|
|
||
| @Test | ||
| // POI LocaleUtil.getLocaleCalendar dates MAPI times in the default calendar (TIKA-4920) | ||
| @DisabledIf("org.apache.tika.test.TestLocales#nonGregorianDefault") |
| */ | ||
| @Test | ||
| // junrar FileHeader.getDateDos uses Calendar.getInstance() (TIKA-4920) | ||
| @DisabledIf("org.apache.tika.test.TestLocales#nonGregorianDefault") |
|
|
||
| @Test | ||
| // commons-compress ZipUtil.dosToJavaDate uses Calendar.getInstance() (TIKA-4920) | ||
| @DisabledIf("org.apache.tika.test.TestLocales#nonGregorianDefault") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…at it found
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)./mvnw clean install(clean testalone cannot resolve the pipes plugin zips)Generated-by: <tool>in the commit message), and consider running the pre-flight in.skills/devs/pr-review/SKILL.md— fix what it finds; don't paste its report heremainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!