SOLR-16398: Migrate SplitCore from @EndPoint/@Command to JAX-RS by epugh · Pull Request #4179 · apache/solr

epugh · 2026-03-03T10:45:09Z

https://issues.apache.org/jira/browse/SOLR-16398

This migrates SplitCore to JAX-RS and moves the business logic into the v2 classes

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

…client via getSolrClient() Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

…sts after JAX-RS migration Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

…cks after JAX-RS migration Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

gerlowskija · 2026-04-07T15:50:57Z

The PR description here doesn't look right - it talks only about a failure in TestApiFramework, which doesn't really seem like the point of this PR.

gerlowskija · 2026-04-07T15:52:01Z

Is there a JIRA associated with this PR? Should there be?

gerlowskija · 2026-04-07T16:04:56Z

+import org.junit.Test;
+
+/** Tests for the split shard V2 endpoint via the generated SolrJ client. */
+public class SplitShardAPITest extends SolrTestCaseJ4 {


[-0] Any reason you created a new test class as opposed to adding the error-case test to SplitShardTest or a similar existing test class? That'd be my slight preference IMO.

gerlowskija · 2026-08-24T12:45:12Z

@epugh - is this something you're looking to resume?

epugh · 2026-08-24T12:53:31Z

@epugh - is this something you're looking to resume?

Yes, but I don't have an immediate plan for this. And honestly, I don't even know if I would use this PR, or just start fresh based on what I've learned since this journey started. And if someone else wants to pick it up, aboslutly ready to support ;-)

…itcoreapi-to-jaxrs

…egate to V2 logic.

…ate to v2.

epugh · 2026-08-28T18:03:36Z

Is there a JIRA associated with this PR? Should there be?

there is already, upated it to reflect hat.

epugh · 2026-08-28T18:03:48Z

The PR description here doesn't look right - it talks only about a failure in TestApiFramework, which doesn't really seem like the point of this PR.

fixed!!!

epugh · 2026-08-28T18:13:40Z

@gerlowskija okay, this has a had a good work out... Would love your review...

github-actions · 2026-10-28T00:12:33Z

This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!

gerlowskija · 2026-11-04T14:12:48Z

Hey @epugh - I noticed that a different PR went in recently that migrated SplitShard to JAX-RS. Is this PR still valid?

Sorry my delay caused it to sit for so long, but if we rescope the PR to be SplitCore only I can try to review more promptly this time!

epugh · 2026-11-04T14:45:04Z

Hey @epugh - I noticed that a different PR went in recently that migrated SplitShard to JAX-RS. Is this PR still valid?

Sorry my delay caused it to sit for so long, but if we rescope the PR to be SplitCore only I can try to review more promptly this time!

No worries! Yeah, this one is so old from that first burp of Copilot generated migrations, from before we had our V2 Apis Convention doc! Yeah, if you want to narrow to just SplitCore, that would be great. Let me update this to main branch first however...

epugh · 2026-11-04T21:33:51Z

@gerlowskija okay, this has been cut down to just "SplitCore"!

SplitOp defaulted the missing 'core' param to "" instead of null, so SplitCoreAPI.splitCore()'s ensureRequiredParameterProvided() null-check never fired. Execution then reached CoreAdminAPIBase.handlePotentiallyAsynchronousTask(), whose finally block unconditionally calls rsp.setHttpCaching(false) — in this test, rsp is null, so that NPE masked the "core container missing" SolrException, and CoreAdminOperation's catch-all rewrapped it as a 500. Every other CoreAdminOp uses params.required().get(CORE) or an early ensureRequiredParameterProvided() check precisely to avoid ever reaching that finally block when the core name is absent; SplitOp is brought in line with that pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RwsEje8u9apx3SRzissZm

…Task's finally block An unconditional rsp.setHttpCaching(false) in the finally block meant that whenever rsp was null, the resulting NPE silently replaced whatever SolrException (BAD_REQUEST or otherwise) had just been thrown in the try block, which CoreAdminOperation's catch-all then rewrapped as a generic 500. This affects every V2 core-admin API built on CoreAdminAPIBase, not just split. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018RwsEje8u9apx3SRzissZm

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: epugh <22395+epugh@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit 1c673ce)

Copilot AI and others added 8 commits February 28, 2026 14:54

Initial plan

f4b6a3f

Migrate SplitCoreAPI from @EndPoint/@command to JAX-RS annotations

c00a0c6

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

refactor the test

97032bd

Migrate SplitShardAPI from @EndPoint/@command to JAX-RS annotations

032f4e7

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

Update Reference Guide for SplitShard and SplitCore V2 API changes

2fd70c2

Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

Update SplitShardAPITest and SplitCoreAPITest to use generated SolrJ …

6d6650b

…client via getSolrClient() Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

Fix TestCollectionAPIs.testCommands: remove obsolete split command te…

23fe06a

…sts after JAX-RS migration Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

Fix TestApiFramework.testFramework: remove obsolete split command che…

7871ac6

…cks after JAX-RS migration Co-authored-by: epugh <22395+epugh@users.noreply.github.com>

github-actions Bot added documentation Improvements or additions to documentation tests cat:api labels Mar 3, 2026

doc change

b10db93

gerlowskija requested changes Apr 7, 2026

View reviewed changes

epugh added 4 commits August 28, 2026 08:37

Merge remote-tracking branch 'upstream/main' into copilot/migrate-spl…

93b1df7

…itcoreapi-to-jaxrs

Bringing this PR up to date with what we've learned about V2 styles..

459d0a1

Migrate split shard logic from v1 to v2 SplitShardAPI, letting v1 del…

a0dc337

…egate to V2 logic.

Migrate split core logic from v1 to v2 SplitCoreAPI, letting v1 deleg…

58b4137

…ate to v2.

github-actions Bot added the cat:cloud label Aug 28, 2026

epugh marked this pull request as ready for review August 28, 2026 17:47

epugh changed the title ~~Migrate SplitCore and SplitShard to Jax-rs~~ Migrate SplitCore and SplitShard APIs from @EndPoint/@Command to JAX-RS Aug 28, 2026

epugh changed the title ~~Migrate SplitCore and SplitShard APIs from @EndPoint/@Command to JAX-RS~~ SOLR-16398: Migrate SplitCore and SplitShard APIs from @EndPoint/@Command to JAX-RS Aug 28, 2026

lint

7b67d36

epugh requested a review from gerlowskija August 28, 2026 18:13

github-actions Bot added the stale PR not updated in 60 days label Oct 28, 2026

Merge branch 'main' into copilot/migrate-splitcoreapi-to-jaxrs

5e63698

epugh added 2 commits November 4, 2026 15:49

Merge upstream/main and scope the JAX-RS migration to SplitCore

bd634e5

Review for conformity to conventions

d66c184

epugh changed the title ~~SOLR-16398: Migrate SplitCore and SplitShard APIs from @EndPoint/@Command to JAX-RS~~ SOLR-16398: Migrate SplitCore from @EndPoint/@Command to JAX-RS Nov 4, 2026

github-actions Bot removed the cat:cloud label Nov 4, 2026

github-actions Bot removed the stale PR not updated in 60 days label Nov 5, 2026

epugh and others added 2 commits November 10, 2026 12:59

epugh merged commit 1c673ce into apache:main Nov 10, 2026
6 of 7 checks passed

epugh added this to the 10.x milestone Nov 10, 2026

Conversation

epugh commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gerlowskija commented Apr 7, 2026

Uh oh!

gerlowskija commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gerlowskija Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gerlowskija commented Aug 24, 2026

Uh oh!

epugh commented Aug 24, 2026

Uh oh!

epugh commented Aug 28, 2026

Uh oh!

epugh commented Aug 28, 2026

Uh oh!

epugh commented Aug 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

gerlowskija commented Nov 4, 2026

Uh oh!

epugh commented Nov 4, 2026

Uh oh!

epugh commented Nov 4, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

epugh commented Mar 3, 2026 •

edited

Loading