Repository navigation
Conversation
janhoy
approved these changes
Nov 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kv_to_mapsplits eachkey:valuepair withkv.split(":"), so any value that contains a colon crashes the command before it starts. It parses--workload-params,--telemetry-params,--plugin-params,--cluster-config-paramsand the CSV form of--client-options, so a URL, a password or a time of day all fail the same way:Keys never contain a colon, so the fix splits on the first colon only (
kv.split(":", 1)). The rest of the value, quoting included, is handled as before.Tested: added
test_kv_to_map_value_contains_colon(a URL, an unquoted password and a time); it fails on main and passes with the fix.ruff checkis clean and the full unit suite passes (1181 passed, 5 skipped).