Repository navigation
feat: support envFrom on Solr pods - #877
Open
Anurag-S1ngh wants to merge 2 commits into
Open
Anurag-S1ngh wants to merge 2 commits into
Anurag-S1ngh wants to merge 2 commits into
Conversation
Why: pod options only allow inline environment variables, so a SolrCloud cannot load a ConfigMap or Secret into the container environment the way a plain StatefulSet can. Add EnvFrom next to EnvVariables and regenerate the deepcopy and CRD schemas, which also exposes it on the Prometheus exporter because both share PodOptions.
Why: the API now accepts envFrom sources but the generated StatefulSet ignored them. Append the configured sources to the Solr container and assert them in the pod-options reconcile test, so a ConfigMap or Secret reaches the container environment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
envFromtoPodOptions, so a SolrCloud can load a ConfigMap or Secret into the Solr container environment the way a plain StatefulSet can, instead of only inlineenvVars.SolrPrometheusExporteralso gains the field because it sharesPodOptions.Fixes #677
Test plan
go build ./...go vet ./...go test ./api/... ./controllers/...withKUBEBUILDER_ASSETSfromsetup-envtest use 1.36.0: all pass, including the envtest controllers suite