Repository navigation
Fixed: Field groups inherited through form extends still render with the parent form (OFBIZ-13766) - #2483
Merged
Conversation
When a form extended another, it reused the parent's FieldGroup instances, and each FieldGroup keeps the form that created it, so the child's inherited groups opened and closed the single-form wrapper with the parent form and decided whether to show a group from the parent's fields and use-when conditions. The child now copies each inherited FieldGroup for itself, keeping its id, style, title and collapsible flags, and maps the inherited field names to the copies; banners hold no form and are still shared. A unit test checks that an inherited group belongs to the child and renders with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a form extended another, it reused the parent's FieldGroup instances, and each FieldGroup keeps the form that created it, so the child's inherited groups opened and closed the single-form wrapper with the parent form and decided whether to show a group from the parent's fields and use-when conditions. The child now copies each inherited FieldGroup for itself, keeping its id, style, title and collapsible flags, and maps the inherited field names to the copies; banners hold no form and are still shared. ModelFormTest checks that an inherited group belongs to the child and renders with it.