Skip to content

packaging: make LZF coredump support optional #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 1 commit into from
Sep 2, 2026
Merged

packaging: make LZF coredump support optional #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ dependencies = [
"pexpect",
"psutil",
"pyserial",
"lzf",
"pytest",
"pytest-dependency",
"pytest-html",
Expand All @@ -54,6 +53,11 @@ keywords = [
"ntfc",
]

[project.optional-dependencies]
coredump = [
"lzf",
]

[project.scripts]
ntfc = "ntfc.cli.main:main"

Expand Down
2 changes: 1 addition & 1 deletion src/ntfc/debug/coredump/syslog_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import struct
from typing import TYPE_CHECKING, Optional

import lzf # type: ignore[import-untyped]
import lzf # type: ignore

from ntfc.debug.coredump.base import CoredumpHandler
from ntfc.log.logger import logger
Expand Down
3 changes: 2 additions & 1 deletion src/ntfc/debug/getdebug.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
from ntfc.debug.coredump.gdb_handler import GdbHandler
from ntfc.debug.coredump.local_file_handler import LocalFileHandler
from ntfc.debug.coredump.manager import CoredumpManager
from ntfc.debug.coredump.syslog_handler import SyslogHandler
from ntfc.debug.coredump.ymodem_handler import YmodemHandler
from ntfc.debug.gdb.controller import GdbController
from ntfc.lib.fastboot.controller import FastbootController
Expand Down Expand Up @@ -230,6 +229,8 @@ def _register_coredump_handlers(
mgr.register(LocalFileHandler(cfg.local_file))

if cfg.syslog.enable:
from ntfc.debug.coredump.syslog_handler import SyslogHandler

mgr.register(SyslogHandler(product.core(0).device))


Expand Down