Repository navigation
wireless/ieee802154: minor fixes for i8sak - #3900
Merged
Merged
Conversation
Add the missing blank lines after the declarations in i8sak_main.c and align a case label in i8sak_reset.c. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
Use the NuttX form, "Name:" with the name of the function that follows. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
With -d or -m the option string was sent as the payload instead of the payload argument, and each tx confirm left a post on sigsem that ended the next poll or assoc early. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
Each acceptassoc added a receiver and a daemon user, the receivers ran out after three calls: replace the previous one. assoc and poll waited forever for a confirm when their receiver could not be registered. The event thread needs a SIGINT handler, an ignored signal does not break it out of MAC802154IOC_GET_EVENT. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
The argument helpers exited with the instance locked, every later i8sak command then blocked. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
sixlowpan_disassoc_req() was defined as sixlowpan_desassoc_req(), and the orphan response functions passed an uninitialized argument to the MAC. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
…tart A daemon that failed to open the device never signalled its start, so the caller blocked forever, and a failed start left the daemon user counted. i8sak_requestdaemon() ends the command on any failure. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
A command that exited after requesting the daemon left its event receiver registered and the daemon running, and a failed instance setup exited with the instance on the active list. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
blaster requested the daemon before parsing its options and kept it on a help or error exit and on quit, and a failed socket bind exited the whole daemon from the blaster thread. Assisted-by: Claude Code Signed-off-by: raiden00pl <raiden00@railab.me>
xiaoxiang781216
approved these changes
Oct 22, 2026
cederom
approved these changes
Oct 22, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @raiden00pl :-)
acassis
approved these changes
Oct 23, 2026
jerpelea
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix various issues found while working on IEEE 802.15.4
Impact
minor bugs
Testing
IEEE 802.15.4 on nordic chips