Skip to content

MINIFICPP-2941 Fix missing tests in behave test runs - #2295

Open
lordgamez wants to merge 1 commit into
apache:mainfrom
lordgamez:MINIFICPP-2941
Open

lordgamez wants to merge 1 commit into
apache:mainfrom
lordgamez:MINIFICPP-2941

Conversation

@lordgamez

Copy link
Copy Markdown
Contributor
  • Fix python import issues that caused silent feature initialization failure
  • Replace 0-example Scenario Outlines with Scenarios to fix missing test scenarios
  • Add behave test dry run as a separate CI step to avoid silent initialization failures in the future
  • Fix S3 proxy host handling to accept http:// prefix
  • Remove https:// comment from description as it is unsupported

https://issues.apache.org/jira/browse/MINIFICPP-2941


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

- Fix python import issues that caused silent feature initialization failure
- Replace 0-example Scenario Outlines with Scenarios to fix missing
  test scenarios
- Add behave test dry run as a separate CI step to avoid silent
  initialization failures in the future
- Fix S3 proxy host handling to accept http:// prefix
- Remove https:// comment from description as it is unsupported
@szaszm

szaszm commented Nov 4, 2026

Copy link
Copy Markdown
Member

Sorry, I've submitted the +1 after reading the diffs without realizing that it's still a draft. Is the work incomplete, or did you just keep it in draft while the CI was running?

@lordgamez
lordgamez marked this pull request as ready for review November 5, 2026 08:55
@lordgamez

Copy link
Copy Markdown
Contributor Author

Sorry, I've submitted the +1 after reading the diffs without realizing that it's still a draft. Is the work incomplete, or did you just keep it in draft while the CI was running?

There were still some issues in the previous run so I just wanted to wait for the CI to finish while doing some additional testing locally, but everything seems to be okay now, so I moved it from draft.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants