Repository navigation
Fix SCM URL normalization for queries and scp URLs - #344
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
Preserve query and fragment suffixes when normalising URL paths, and avoid treating scp-like SCM connections as file-system paths.\n\nFixes apache#335
elharo
requested changes
Oct 30, 2026
elharo
left a comment
elharo
left a comment
Contributor
There was a problem hiding this comment.
Why is this using String operations instead of a URL parser like java.net.URI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335.
ModelInheritanceAssembler.appendPathnow normalises URL paths without changing query strings or fragments, preserves scp-like SCM connections, and appends child paths before URL suffixes.mvn -Prun-its verifypassed on JDK 21 (61 unit tests and 12 integration tests);mvn spotless:checkpassed.To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following: