Repository navigation
fix(agent-isolation): scope touch dismissals to each operation - #1894
Open
leninworld wants to merge 1 commit into
Open
leninworld wants to merge 1 commit into
leninworld wants to merge 1 commit into
Conversation
Share real signer identity across wrapper and hook watchers. Clear only an empty completed-authentication dismissal while holding the window lease. Keep conservative fallback and owner cleanup, and cover both regressions. The existing software-key signing test now takes the shared process lock; the setup fingerprint is regenerated by its required hook. Fixes apache#1834 Generated-by: Codex (desktop 26.1013.40934) Generated-by: Claude Desktop 4.29.0 (Opus 5.5 review)
github-actions
Bot
added
family:setup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| """Also end an orphaned signer after the abnormal-owner test.""" | ||
| try: | ||
| os.killpg(proc.pid, signal.SIGTERM) | ||
| except ProcessLookupError: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1834.
Summary
Type of change
tools/*/withpyproject.toml)Test plan
uv run --frozen prek run --all-files --skip workspace-pytestpasses, including workspace Ruff, formatting, mypy, links and spec checks.Linux ARM64, Python 3.12.12, frozen workspace lock. The skips cover unavailable GUI/Tk, zsh, ambient Node, private-home and trusted-Python scenarios. No physical hardware or macOS GUI validation is claimed. Scoped test-file Ruff reports the same 45 existing diagnostics before and after, with none added.
RFC-AI-0004 compliance
Gen-AI disclosure
Generative AI was used to prepare the code, tests and this description with Codex (desktop version 26.1013.40934), independently reviewed with Claude Desktop 4.29.0 (Opus 5.5). I have personally read and understood the final diff.
Linked issues
Closes #1834.