Repository navigation
Fix size-only backup scan for prefix siblings - #339
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
…ckup-prefix-sibling
- size and once rolling no longer count log.txt.errors.3 as backup 3 - the static name guard from apache#334 now covers names without dates
Contributor
|
Thanks @dajiaohuang, the bug is real and your fix is right. We reshaped it a little before merging:
Here is the commit on top of your branch: 2fbda3d Could you pull it into your branch and push? It applies without conflicts, and we squash when merging the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338.
Summary
Verification
CurrentSizeRollBackupswas 5 instead of 0) and passed with this change.dotnet test src/log4net.sln --no-restore: 462log4net.Testspassed, 1 skipped; 52log4net.Ext.Mail.Testspassed. Restore reported NU1902/NU1903 advisories forSystem.Security.Cryptography.Pkcs10.0.0 inlog4net.Ext.Mail.Tests; this PR does not change that dependency.AI/tool disclosure: prepared with OpenAI Codex gpt-6-luna, operated by dajiaohuang. The tests above were executed by the agent; this disclosure does not claim independent human-authored verification.