Repository navigation
KNOX-3536: JDBCTokenStateService fails on PostgreSQL in HA: duplicate… - #1477
Merged
Merged
Conversation
… key on pg_type_typname_nsp_index during concurrent table creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… key on pg_type_typname_nsp_index during concurrent table creation
KNOX-3536 - JDBCTokenStateService fails on PostgreSQL in HA: duplicate key on pg_type_typname_nsp_index during concurrent table creation
What changes were proposed in this pull request?
The Postgres token DDL scripts wrap CREATE TABLE IF NOT EXISTS in pg_advisory_lock / pg_advisory_unlock. JDBCUtils.createTableFromSQL sends the whole script in a single Statement.execute(), and PostgreSQL runs it as one implicit transaction. As a result, the unlock happens before the CREATE TABLE is committed. When several Knox instances start at the same time, another instance can then take the lock, fail to see the uncommitted table, and fail with duplicate key value violates unique constraint "pg_type_typname_nsp_index".
This PR switches both scripts (createKnoxTokenDatabaseTablePostgres.sql, createKnoxTokenMetadataDatabaseTablePostgres.sql) to pg_advisory_xact_lock(12345) and removes the explicit unlock. That lock is released only after the transaction commits.
How was this patch tested?
Tested locally the script on a postgres 16 db running in docker